It's very easy to criticise the portfolio theory, pointing out the many times when it has failed to predict market crashes, and major movements. However, measures other than volatility tend to be even poorer predictors. Major crashes are the result of factors hitherto unconsidered, not a failure of portfolio theory - which is actually a framework for thought, rather than the alpha and omega of portfolio analysis.